xfs
[Top] [All Lists]

TAKE 974905 - Initialise current offset in xfs_file_readdir correctly

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 974905 - Initialise current offset in xfs_file_readdir correctly
From: dgc@xxxxxxx (David Chinner)
Date: Thu, 20 Dec 2007 16:33:15 +1100 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Initialise current offset in xfs_file_readdir correctly

After reading the directory contents into the temporary buffer, we
grab each dirent and pass it to filldir witht eh current offset of
the dirent. The current offset was not being set for the first
dirent in the temporary buffer, which coul dresult in bad offsets
being set in the f_pos field result in looping and duplicate entries
being returned from readdir.

Date:  Thu Dec 20 16:32:49 AEDT 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  tes@xxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30282a
fs/xfs/linux-2.6/xfs_file.c - 1.161 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_file.c.diff?r1=text&tr1=1.161&r2=text&tr2=1.160&f=h
        - Initialise the curr_offset correctly for the first dirent in each temp
          buffer during readdir.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 974905 - Initialise current offset in xfs_file_readdir correctly, David Chinner <=