xfs
[Top] [All Lists]

PARTIAL TAKE 974873 - Fix mknod regression

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: PARTIAL TAKE 974873 - Fix mknod regression
From: dgc@xxxxxxx (David Chinner)
Date: Wed, 19 Dec 2007 14:18:28 +1100 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Fix mknod regression

This was broken by my '[XFS] simplify xfs_create/mknod/symlink prototype',
which assigned the re-shuffled ondisk dev_t back to the rdev variable in
xfs_vn_mknod.  Because of that i_rdev is set to the ondisk dev_t instead
of the linux dev_t later down the function.

Fortunately the fix for it is trivial:  we can just remove the
assignment because xfs_revalidate_inode has done the proper job before
unlocking the inode.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Date:  Wed Dec 19 14:17:51 AEDT 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxxxxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30273a
fs/xfs/linux-2.6/xfs_iops.c - 1.272 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.272&r2=text&tr2=1.271&f=h
        - fix xfs_vn_mknod regression due to writing the wrong format dev_t to
          i_rdev.



<Prev in Thread] Current Thread [Next in Thread>
  • PARTIAL TAKE 974873 - Fix mknod regression, David Chinner <=