xfs
[Top] [All Lists]

TAKE 971596 - Fixed a few bugs in xfs_buf_associate_memory()

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 971596 - Fixed a few bugs in xfs_buf_associate_memory()
From: lachlan@xxxxxxx (Lachlan McIlroy)
Date: Tue, 27 Nov 2007 13:22:56 +1100 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Fixed a few bugs in xfs_buf_associate_memory()

- calculation of 'page_count' was incorrect as it did not
  consider the offset of 'mem' into the first page.  The
  logic to bump 'page_count' didn't work if 'len' was <=
  PAGE_CACHE_SIZE (ie offset = 3k, len = 2k).
- setting b_buffer_length to 'len' is incorrect if
  'offset' is > 0.  Set it to the total length of the
  buffer.
- I suspect that passing a non-aligned address into
  mem_to_page() for the first page may have been causing
  issues - don't know but just tidy up that code anyway.

Date:  Tue Nov 27 13:21:49 AEDT 2007
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-bufmem
Inspected by:  hch
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30143a
fs/xfs/linux-2.6/xfs_buf.c - 1.249 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_buf.c.diff?r1=text&tr1=1.249&r2=text&tr2=1.248&f=h
        - Fixed a few bugs in xfs_buf_associate_memory().




<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 971596 - Fixed a few bugs in xfs_buf_associate_memory(), Lachlan McIlroy <=