xfs
[Top] [All Lists]

TAKE 972755 - Fix sparse warning in xlog_recover_do_efd_trans.

To: sgi.bugs.xfs@xxxxxxxxxxxx
Subject: TAKE 972755 - Fix sparse warning in xlog_recover_do_efd_trans.
From: dgc@xxxxxxx (David Chinner)
Date: Fri, 2 Nov 2007 12:45:12 +1100 (EST)
Cc: xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Fix sparse warning in xlog_recover_do_efd_trans.

Sparse trips over the locking order in xlog_recover_do_efd_trans()
when xfs_trans_delete_ail() drops the ail lock. Because the unlock
is conditional, we need to either annotate with a "fake unlock" or
change the structure of the code so sparse thinks the function
always unlocks.

Reordering the code makes it simpler, so do that.


Date:  Fri Nov  2 12:44:49 AEDT 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@xxxxxxxxxxxxx, lachlan@xxxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:30003a
fs/xfs/xfs_log_recover.c - 1.332 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log_recover.c.diff?r1=text&tr1=1.332&r2=text&tr2=1.331&f=h
        - Fix sparse warning in xlog_recover_do_efd_trans.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 972755 - Fix sparse warning in xlog_recover_do_efd_trans., David Chinner <=