| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] kill unnessecary ioops indirection |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Wed, 19 Sep 2007 13:03:18 +0200 |
| Cc: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <46F07E79.8090605@sgi.com> |
| References: | <20070914162802.GE7110@lst.de> <46EF661C.4030500@sgi.com> <20070918192327.GA24369@lst.de> <46F07E79.8090605@sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Wed, Sep 19, 2007 at 11:42:17AM +1000, Lachlan McIlroy wrote: > >vn_to_inode()/vn_from_inode() are no-ops nowdays, btw. > Yeah I know - that's why I'd like to get rid of them. They make the > code ugly and give the impression we need to work with two different > objects. There's lots of places where we declare an extra pointer on > the stack when we don't need to. Anyway that's fodder for another > patch, this patch looks good now. Yes, eventually we should get rid of them. I have a patch for the functions prototypes in xfs_vnodeops.h somewhere, and fixing the dmapi interface to avoid vnodes is also high on my todo list. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: can't remove dir, Barry Naujok |
|---|---|
| Next by Date: | Re: [PATCH 3/4] simplify xfs_vn_getattr, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/2] kill unnessecary ioops indirection, Lachlan McIlroy |
| Next by Thread: | [PATCH 2/2] kill xfs_iocore_t, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |