Re: [PATCH] refactor xfs_mountfs for clarity & stack savings

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

Looks goo to me except for a tiny nitpick:

> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx
> +             if ((error = xfs_readsb(mp, mfsi_flags))) {
> +                     return error;
> +             }

> +     if ((error = xfs_update_alignment(mp, mfsi_flags, &update_flags)))
> +             goto error1;

> +     if ((error = xfs_check_sizes(mp, mfsi_flags)))
> +             goto error1;

>       if ((error = xfs_rtmount_init(mp))) {

Please make sure the assignment and conditional are on separate lines
for all of these once you're cleaning up this function.  In the first
case there's also some braces to remove.