xfs
[Top] [All Lists]

Re: Review: Multi-File Data Streams V2

To: David Chinner <dgc@xxxxxxx>
Subject: Re: Review: Multi-File Data Streams V2
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 16 Jun 2007 21:38:51 +0100
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070613041629.GI86004887@sgi.com>
References: <20070613041629.GI86004887@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.3i
Thanks, this version looks a lot better now.

The pip checks in xfs_inode.c are still in, but I'm pretty sure they're
not nessecary, and even if they were nessecary they'd need a good comment
explaining why.

The patch still hooks into xfs_close despite your comment that you
updated it for the removal of it.

I still strongly believe the mru cache should not be inside xfs.  It's
a completely generic library function and should go into lib/ so it's
available to all of the kernel.  That means it'll need some codingstyle
updates and proper kerneldoc comments, though.


<Prev in Thread] Current Thread [Next in Thread>