| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH] get rid of file_count abuse |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Fri, 8 Jun 2007 16:24:30 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20070604143352.GA8721@lst.de> |
| References: | <20070604143352.GA8721@lst.de> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Mon, Jun 04, 2007 at 04:33:52PM +0200, Christoph Hellwig wrote: > A check for file_count is always a bad idea. Linux has the ->release > method to deal with cleanups on last close and ->flush is only for the > very rare case where we want to perform an operation on every drop of > a reference to a file struct. *nod* > This patch gets rid of vop_close and surrounding code in favour of > simply doing the page flushing from ->release. Added to my qa tree, and mangled to move the filestreams stuff from xfs_close to xfs_release as well. Thanks, Christoph. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: Be smarter about handling ENOSPC during writeback, Timothy Shimmin |
|---|---|
| Next by Date: | Re: Review: Be smarter about handling ENOSPC during writeback, David Chinner |
| Previous by Thread: | [PATCH] get rid of file_count abuse, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] kill macro noise in xfs_dir2*.h, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |