xfs
[Top] [All Lists]

[PATCH] Fix disable, enable, off and remove commands in xfs_quota.

To: xfs@xxxxxxxxxxx
Subject: [PATCH] Fix disable, enable, off and remove commands in xfs_quota.
From: Utako Kusaka <utako@xxxxxxxxxxxxxx>
Date: Mon, 07 May 2007 10:37:56 +0900
Cc: tes@xxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
Hi,

I send this mail 10 days ago but it got lost... 

disable, enable, off and remove commands in xfs_quota don't work.
Because:
1) The argument type to quotactl() is wrong.
   "addr" is fs_quota_stat_t structure in the original code but
   it should be an unsigned int as shown in man page.
   (disable, enable, off and remove)
2) The wrong flag is used for -ugp option check.
   (disable, enable, off and remove)
3) The accounting flag (XFS_QUOTA_*DQ_ACCT) is used for disabling quota
   enforcement incorrectly. 
   (disable)
4) The accounting and enforcement flag is used for removing space incorrectly.
   (remove)
5) The quota types must be specified to quotactl() one by one.
   But multiple quota types are passed to quotactl() when specifying -ug|-up 
option.
   (remove)

Attached patch fixes these problems.

Signed-off-by: Utako Kusaka <utako@xxxxxxxxxxxxxx>
---

Attachment: state.diff
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] Fix disable, enable, off and remove commands in xfs_quota., Utako Kusaka <=