xfs
[Top] [All Lists]

Re: review [1 of 3]: lazy superblock counters - core kernel

To: David Chinner <dgc@xxxxxxx>
Subject: Re: review [1 of 3]: lazy superblock counters - core kernel
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 24 Apr 2007 09:51:47 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070424012808.GD48531920@melbourne.sgi.com>
References: <20070419231459.GX48531920@melbourne.sgi.com> <20070423220010.GA18325@infradead.org> <20070424012808.GD48531920@melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Tue, Apr 24, 2007 at 11:28:08AM +1000, David Chinner wrote:
> > This is really quite nasty.  Should we at least force a cache flush here?
> 
> Ok, so the patch I sent out was an older version that had a very similar
> name to the current patch in my series (xfs-lazy-sb vs xfs_lazy_sb).
> This code doesn't exist in the version I should have sent out.
> 
> The latest version, plus the changes suggested here and with the
> second patch folded back into it is attached.

Looks like in the new code we simply ignore log reservation
failures in xfs_log_sbcount?

Otherwise this looks good to me.

converting all sb feature checks to use the inlines would be
a nice cleanup opportunity for someone bored :)


<Prev in Thread] Current Thread [Next in Thread>