| To: | xfs-dev <xfs-dev@xxxxxxx> |
|---|---|
| Subject: | Review - flush blockdev on close |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Tue, 24 Apr 2007 11:42:49 +1000 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
As suggested by Christoph, we probably should flush the block
device as we complete the process of unmounting the filesystem.
Patch attached.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
---
fs/xfs/linux-2.6/xfs_buf.c | 1 +
1 file changed, 1 insertion(+)
Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24
09:32:22.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 11:12:42.181361346
+1000
@@ -1464,6 +1464,7 @@ xfs_free_buftarg(
int external)
{
xfs_flush_buftarg(btp, 1);
+ xfs_blkdev_issue_flush(btp);
if (external)
xfs_blkdev_put(btp->bt_bdev);
xfs_free_bufhash(btp);
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: review [1 of 3]: lazy superblock counters - core kernel, David Chinner |
|---|---|
| Next by Date: | Re: review: don't hold ilock when calling vn_iowait, Timothy Shimmin |
| Previous by Thread: | PARTIAL TAKE 940392 - unwritten extents aren't converted when modified through mmap, David Chinner |
| Next by Thread: | Re: Review - flush blockdev on close, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |