xfs
[Top] [All Lists]

Re: review: don't hold ilock when calling vn_iowait

To: David Chinner <dgc@xxxxxxx>
Subject: Re: review: don't hold ilock when calling vn_iowait
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 23 Apr 2007 22:43:38 +0100
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070422230303.GX32602149@melbourne.sgi.com>
References: <20070422230303.GX32602149@melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
On Mon, Apr 23, 2007 at 09:03:03AM +1000, David Chinner wrote:
> 
> Regression introduced by recent freezing fixes - we should
> not hold the ilock while waiting for I/O completion.

Looks good, and actually simplies the twisted maze the xfs_sync_inodes is
a little bit.  And the missing IPOINTER_INSERT in the SYNC_CLOSE case
looks like an actual bugfix.

Of course in the end I'd still like to see all pagecache-writeout to
be driven by sync_sb_inodes() instead of the fs code, but it'll probably
take a little longer until that is done.


<Prev in Thread] Current Thread [Next in Thread>