| To: | Barry Naujok <bnaujok@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_repair - move realtime extent processing to a separate function |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Apr 2007 08:26:47 +0100 |
| Cc: | xfs@xxxxxxxxxxx, "'xfs-dev'" <xfs-dev@xxxxxxx> |
| In-reply-to: | <200704130415.OAA16550@larry.melbourne.sgi.com> |
| References: | <200704130415.OAA16550@larry.melbourne.sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.2i |
On Fri, Apr 13, 2007 at 02:22:10PM +1000, Barry Naujok wrote: > While changing the process_bmbt_reclist_int() function, I observed a > realtime check inside the block map get/set state loop which is quite > CPU intensive. Upon further investigation, this loop is not used at > all for realtime extents and that the two types of extents are pretty > much processed exclusively. > > So, I simplified the functionality by moving the realtime extent > processing into it's own function and fixing a bug at the same time > when it comes to realtime inodes with attributes (it was comparing > attr extents to the realtime volume bmap instead of the normal bmap). Nice cleanup, looks good. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] remove the unnecessary word in the log message., Christoph Hellwig |
|---|---|
| Next by Date: | Re: [RFC] add FIEMAP ioctl to efficiently map file allocation, Christoph Hellwig |
| Previous by Thread: | [PATCH] xfs_repair - move realtime extent processing to a separate function, Barry Naujok |
| Next by Thread: | TAKE 963465 - export xfs_buftarg_list for xfsidbg (using func), Tim Shimmin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |