xfs
[Top] [All Lists]

Re: Announce: new-aops-1 for 2.6.21-rc3

To: Nick Piggin <npiggin@xxxxxxx>
Subject: Re: Announce: new-aops-1 for 2.6.21-rc3
From: Mark Fasheh <mark.fasheh@xxxxxxxxxx>
Date: Thu, 15 Mar 2007 14:08:48 -0700
Cc: Linux Filesystems <linux-fsdevel@xxxxxxxxxxxxxxx>, reiserfs-list@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, nfs@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20070315161704.GH8321@wotan.suse.de>
Organization: Oracle Corporation
References: <20070315161704.GH8321@wotan.suse.de>
Reply-to: Mark Fasheh <mark.fasheh@xxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.11
On Thu, Mar 15, 2007 at 05:17:04PM +0100, Nick Piggin wrote:
> OK, I've gone through and fixed several bugs until the thing actually
> survives fsx-linux for both ext2 and ext3 ordered and writeback (both
> when using the new aops, and the legacy prepare_write path). Actually
> ext3 sometimes breaks, but it does in unpatched kernels anyway.

Attached is a bugfix for a crash folks who use an initrd will hit early on.
        --Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@xxxxxxxxxx


From: Mark Fasheh <mark.fasheh@xxxxxxxxxx>

[PATCH] Populate pagep in simple_write_begin()

This wasn't getting passed back to callers.

Signed-off-by: Mark Fasheh <mark.fasheh@xxxxxxxxxx>

cbf20bf51ddd6434db935ba29f845a85f3b1ec65
diff --git a/fs/libfs.c b/fs/libfs.c
index 51f9748..602496a 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -357,6 +357,8 @@ int simple_write_begin(struct file *file
        if (!page)
                return -ENOMEM;
 
+       *pagep = page;
+
        return simple_prepare_write(file, page, from, from+len);
 }
 
-- 
1.3.3


<Prev in Thread] Current Thread [Next in Thread>