On Fri, Oct 06, 2006 at 04:34:03PM +1000, Timothy Shimmin wrote:
> Request for review of libxfs patch.
....
> Index: xfsprogs/libxfs/darwin.c
> ===================================================================
> --- xfsprogs/libxfs/darwin.c.orig 2006-10-06 14:12:27.000000000 +1000
> +++ xfsprogs/libxfs/darwin.c 2006-10-06 14:14:03.000000000 +1000
> @@ -51,8 +51,8 @@
> return (writable == 0);
> }
>
> -void
> -platform_set_blocksize(int fd, char *path, dev_t device, int blocksize)
> +int
> +platform_set_blocksize(int fd, char *path, dev_t device, int blocksize,
> int fatal)
> {
> }
Should "return fatal;" to fail specific setting of this until it is
supported on this platform.
>
> Index: xfsprogs/libxfs/freebsd.c
> ===================================================================
> --- xfsprogs/libxfs/freebsd.c.orig 2006-10-06 14:12:27.000000000 +1000
> +++ xfsprogs/libxfs/freebsd.c 2006-10-06 14:14:03.000000000 +1000
> @@ -91,8 +91,8 @@
> return 0;
> }
>
> -void
> -platform_set_blocksize(int fd, char *path, dev_t device, int blocksize)
> +int
> +platform_set_blocksize(int fd, char *path, dev_t device, int blocksize,
> int fatal)
> {
> return;
> }
Ditto...
> Index: xfsprogs/libxfs/irix.c
> ===================================================================
> --- xfsprogs/libxfs/irix.c.orig 2006-10-06 14:12:27.000000000 +1000
> +++ xfsprogs/libxfs/irix.c 2006-10-06 14:14:03.000000000 +1000
> @@ -36,8 +36,8 @@
> return 1;
> }
>
> -void
> -platform_set_blocksize(int fd, char *path, dev_t device, int blocksize)
> +int
> +platform_set_blocksize(int fd, char *path, dev_t device, int blocksize,
> int fatal)
> {
> return;
> }
and again.
Otherwise looks ok.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
|