Re: review: xfs

To:	Timothy Shimmin <tes@xxxxxxx>
Subject:	Re: review: xfs_copy fix
From:	David Chinner <dgc@xxxxxxx>
Date:	Fri, 6 Oct 2006 16:36:43 +1000
Cc:	xfs-dev@xxxxxxx, xfs@xxxxxxxxxxx
In-reply-to:	<5635EC4CFB723E7E36B51235@timothy-shimmins-power-mac-g5.local>
References:	<5635EC4CFB723E7E36B51235@timothy-shimmins-power-mac-g5.local>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.4.2.1i

On Fri, Oct 06, 2006 at 04:18:10PM +1000, Timothy Shimmin wrote:
> Request for review.
> 
> xfs_copy was seg faulting for me on my x86_64 box.
> This fixes up the variable arg handling for multiple
> vfprintf calls by putting va_start and va_end calls
> around them (never done this before:).

I take it that it was crashing because the LOG flag and one
of ERR or OUT was set so it was trying to do 2 varargs
traversals with only one init?

Looks sane to me.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

<Prev in Thread]	Current Thread	[Next in Thread>
review: xfs_copy fix, Timothy Shimmin Re: review: xfs_copy fix, David Chinner <= Re: review: xfs_copy fix, Timothy Shimmin

Previous by Date:	review: set blocksize patch - libxfs & mkfs, Timothy Shimmin
Next by Date:	Re: review: set blocksize patch - libxfs & mkfs, David Chinner
Previous by Thread:	review: xfs_copy fix, Timothy Shimmin
Next by Thread:	Re: review: xfs_copy fix, Timothy Shimmin
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: review: xfs_copy fix