| To: | Nathan Scott <nathans@xxxxxxx> |
|---|---|
| Subject: | [2.6 patch] fs/xfs/xfs_bmap.c:xfs_bmapi(): fix a bug |
| From: | Adrian Bunk <bunk@xxxxxxxxx> |
| Date: | Sat, 26 Aug 2006 17:06:55 +0200 |
| Cc: | xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.12-2006-07-14 |
This patch fixes the following bug introduced by commit
39269e29d4aad04252e0debec4c9b01bac16a257:
Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
always assigned zero.
Spotted by the GNU C compiler (SVN version).
Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
--- linux-2.6.18-rc4-mm2/fs/xfs/xfs_bmap.c.old 2006-08-26 03:31:23.000000000
+0200
+++ linux-2.6.18-rc4-mm2/fs/xfs/xfs_bmap.c 2006-08-26 03:31:28.000000000
+0200
@@ -4993,7 +4993,7 @@ xfs_bmapi(
bma.firstblock = *firstblock;
bma.alen = alen;
bma.off = aoff;
- bma.conv = (flags & XFS_BMAPI_CONVERT);
+ bma.conv = !!(flags & XFS_BMAPI_CONVERT);
bma.wasdel = wasdelay;
bma.minlen = minlen;
bma.low = flist->xbf_low;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Aborting XFS copy - reason: Cannot allocate memory, Russell Cattelan |
|---|---|
| Next by Date: | Thanks!, Robert Brockway |
| Previous by Thread: | Files greater than 2TB on 32 bit SLES9 SP3?, Stephan Jansen |
| Next by Thread: | Re: [2.6 patch] fs/xfs/xfs_bmap.c:xfs_bmapi(): fix a bug, Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |