xfs
[Top] [All Lists]

XFS fix for 2.6.18-rc5

To: Greg KH <greg@xxxxxxxxx>
Subject: XFS fix for 2.6.18-rc5
From: Nathan Scott <nathans@xxxxxxx>
Date: Thu, 10 Aug 2006 15:48:18 +1000
Cc: Linus Torvalds <torvalds@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, xfs@xxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hi Greg,

Please pull from:
        git://oss.sgi.com:8090/nathans/xfs-rc-2.6

This will update the following files:

 fs/xfs/xfs_alloc.c |  103 +++++++++++++++++++++++++++-------------------------
 1 files changed, 54 insertions(+), 49 deletions(-)

through these commits:

commit 0e1edbd99994270023cea5afe593f972eb09a778
Author: Nathan Scott <nathans@xxxxxxx>
Date:   Thu Aug 10 14:40:41 2006 +1000

    [XFS] Fix xfs_free_extent related NULL pointer dereference.
    
    We recently fixed an out-of-space deadlock in XFS, and part of that fix
    involved the addition of the XFS_ALLOC_FLAG_FREEING flag to some of the
    space allocator calls to indicate they're freeing space, not allocating
    it. There was a missed xfs_alloc_fix_freelist condition test that did not
    correctly test "flags". The same test would also test an uninitialised
    structure field (args->userdata) and depending on its value either would
    or would not return early with a critical buffer pointer set to NULL.
    
    This fixes that up, adds asserts to several places to catch future botches
    of this nature, and skips sections of xfs_alloc_fix_freelist that are
    irrelevent for the space-freeing case.
    
    SGI-PV: 955303
    SGI-Modid: xfs-linux-melb:xfs-kern:26743a
    
    Signed-off-by: Nathan Scott <nathans@xxxxxxx>


-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>