xfs
[Top] [All Lists]

Re: [PATCH] kill leftover WANT_FUNCS macro indirection

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] kill leftover WANT_FUNCS macro indirection
From: Nathan Scott <nathans@xxxxxxx>
Date: Mon, 31 Jul 2006 08:54:54 +1000
Cc: Andi Kleen <ak@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <44CBDFC9.3040202@sandeen.net>; from sandeen@sandeen.net on Sat, Jul 29, 2006 at 05:23:05PM -0500
References: <44CAE247.6020608@sandeen.net> <p73k65w41je.fsf@verdi.suse.de> <44CBDFC9.3040202@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Sat, Jul 29, 2006 at 05:23:05PM -0500, Eric Sandeen wrote:
> Andi Kleen wrote:
> > Eric Sandeen <sandeen@xxxxxxxxxxx> writes:
> > 
> >> This gets rid of some pointless macro defines... I had a version that
> >> lower-cased it all too but Nathan liked this better, and he's the man!
> >> :)
> > 
> > Shouted function names is not exactly Linux code style at least.
> > 
> > -Andi
> > 
> 
> well, *shrug* I have both versions, Nathan can take his pick :)
> 
> honestly, one-liner static inlines isn't exactly linux code style either, tho 
> the typechecking is nice.
> 
> I guess I shouldn't have said "Nathan liked this better" - I think he was 
> being 
> pragmatic about the scope of the change.

Right, its more that we don't have a great track record at the moment
of not introducing regressions with these cleanups (including myself),
so I'm becoming more reluctant to do sweeping changes across the whole
codebase.  Smaller, specific, and obviously-correct things are less 
likely to introduce issues, so if we can achieve basically the same
thing while churning the code less, I'm all for it.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>