xfs
[Top] [All Lists]

Re: Patch to fix segmentation fault in libattr

To: Simon Munton <simon@xxxxxxxxxxxxxxxxxx>
Subject: Re: Patch to fix segmentation fault in libattr
From: Nathan Scott <nathans@xxxxxxx>
Date: Wed, 22 Feb 2006 13:08:47 +1100
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <200602212219.59512.simon@munton.demon.co.uk>; from simon@munton.demon.co.uk on Tue, Feb 21, 2006 at 10:19:59PM +0000
References: <200602212219.59512.simon@munton.demon.co.uk>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Tue, Feb 21, 2006 at 10:19:59PM +0000, Simon Munton wrote:
> Hi
> 
> I found that using the attr command with the -l option could cause a 
> segmentation fault.
> 
> I tracked the problem down to the attr_list function in libattr.c. This 
> contains a loop that uses the value from the listxattr call to determine when 
> the loop finishes. However, this value is overwritten in the loop by the call 
> to getxattr.

Good catch, thanks!  I'll get that fixed up (tend to agree with
Chris re shadow variables - so I'll make it clear with separate
ones).

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>