xfs
[Top] [All Lists]

Re: xfs: Makefile-linux-2.6 => Makefile?

To: Andrew Morton <akpm@xxxxxxxx>
Subject: Re: xfs: Makefile-linux-2.6 => Makefile?
From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Tue, 10 Jan 2006 21:00:54 +0100
Cc: Eric Sandeen <sandeen@xxxxxxx>, hch@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <20060109234532.78bda36a.akpm@osdl.org>
References: <20060109164214.GA10367@mars.ravnborg.org> <20060109164611.GA1382@infradead.org> <43C2CFBD.8040901@sgi.com> <20060109234532.78bda36a.akpm@osdl.org>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.11
On Mon, Jan 09, 2006 at 11:45:32PM -0800, Andrew Morton wrote:
> 
> It'd be nice to fix this:
> 
> bix:/usr/src/25> make fs/xfs/linux-2.6/xfs_iops.o
>   SPLIT   include/linux/autoconf.h -> include/config/*
>   SHIPPED scripts/genksyms/lex.c
>   SHIPPED scripts/genksyms/parse.h
>   SHIPPED scripts/genksyms/keywords.c
>   HOSTCC  scripts/genksyms/lex.o
>   SHIPPED scripts/genksyms/parse.c
>   HOSTCC  scripts/genksyms/parse.o
>   HOSTLD  scripts/genksyms/genksyms
>   HOSTCC  scripts/mod/file2alias.o
>   HOSTCC  scripts/mod/modpost.o
>   HOSTLD  scripts/mod/modpost
> scripts/Makefile.build:15: /usr/src/devel/fs/xfs/linux-2.6/Makefile: No such 
> file or directory
> make[1]: *** No rule to make target 
> `/usr/src/devel/fs/xfs/linux-2.6/Makefile'.  Stop.
> make: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 2

xfs as one of the very few users in the kernel has split up .o files in
several directories. And kbuild does not have support for specifying
that is shall link to a .o file that is being build in a sub-directory.

This is in general noe encouraged for the kernel - it is not common
practice. And therefore not something I have planned to implement.

If there is a general consensus that we like to have this then it is
doable, but it will uglify scripts/Makefile.lib even more.

For xfs this is 37 .o files that are build in three directories.
The easy fix would be to move the files to stay just under the xfs/
directory like all others - but xfs people prefer not to do so to stay
compatible with their external source tree.

        Sam


<Prev in Thread] Current Thread [Next in Thread>