xfs
[Top] [All Lists]

Re: Where/how to submit for review patch for shrink support?

To: linux-xfs@xxxxxxxxxxx
Subject: Re: Where/how to submit for review patch for shrink support?
From: Iustin Pop <iusty@xxxxxxxxx>
Date: Tue, 6 Sep 2005 02:21:26 +0300
In-reply-to: <20050905191031.GB18315@infradead.org>
Mail-followup-to: linux-xfs@xxxxxxxxxxx
References: <20050905185221.GA5209@saytrin.hq.k1024.org> <20050905191031.GB18315@infradead.org>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.10i
On Mon, Sep 05, 2005 at 08:10:31PM +0100, Christoph Hellwig wrote:
> 
> Please try to rediff it against the CVS tree at oss.sgi.com (there's not
> much differences, it's just the development tree), and then submit it to
> the list.
Ok, done (I hope the format is ok).

Notes about the patch:
 - I left the printk's I used in place, maybe they help with
   understanding the code;
 - the xfs_inobtsize and xfs_alloc_btsize are called recursivelly, I
   don't know if this can be a problem with stack usage; however, it was
   the simplest way at the moment and the max depth is equal to the max
   depth of the btrees;
 - almost all the code is based on guesswork and looking at the xfs
   kernel & userspace code; I have the most doubts about the usage of
   xfs_alloc_vextent and the parameters I filled its argument with;

If anything is unclear, please ask for more information.


> Yeah, that sounds a little fishy.  I'll take a look at the patch once
> you'll post it.

Ok, thanks a lot!

Iustin

Attachment: cvs.diff
Description: Text document

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>