xfs
[Top] [All Lists]

Re: force shutdown at xfs_growfs

To: ASANO Masahiro <masano@xxxxxxxxxxxxxx>
Subject: Re: force shutdown at xfs_growfs
From: Nathan Scott <nathans@xxxxxxx>
Date: Wed, 25 Aug 2004 15:30:35 +1000
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20040825.125949.424242868.masano@tnes.nec.co.jp>
References: <20040825.125949.424242868.masano@tnes.nec.co.jp>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.3i
On Wed, Aug 25, 2004 at 12:59:49PM +0900, ASANO Masahiro wrote:
> Hi SGI guys,

Hi there,

> I'm afraid that it is dangerous to grow filesystem by xfs_growfs
> under a situation of heavy file allocation. Because mp->m_maxagi is
> updated before formatting new AGs, and other processes can touch
> them. This causes filesystem shutting down.

Yep, good catch!

> Here is a patch for Linux-2.4.27.
> This patch delays the update of m_maxagi.
> 
> Thank you.

Thank you; your fix looks simple & is clearly correct, I'll check
it in shortly.

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>