Re: oops release-1.3.3-pre2/x86_64 from Scientific Linux

[Tru Huynh <tru@xxxxxxxxxx>]

On Mon, Aug 09, 2004 at 08:52:40AM -0500, Eric Sandeen wrote:
> what does your ffs() look like?  I added this patch to our kernels, but 
> it may not be in Dan's kernels (hm, I need to update the 1.3.3 packages 
> we have on oss...)
> 
> --- linux/include/asm-x86_64/bitops.h.orig      2004-07-26 
> 12:33:54.000000000 -0500
> +++ linux/include/asm-x86_64/bitops.h   2004-07-26 12:35:23.000000000 -0500
> @@ -473,7 +473,7 @@ static __inline__ int ffs(int x)
> 
>          __asm__("bsfl %1,%0\n\t"
>                  "cmovzl %2,%0"
> -               : "=r" (r) : "g" (x), "r" (32));
> +               : "=r" (r) : "rm" (x), "r" (-1));
>          return r+1;
>   }
include/asm-x86_64/bitops.h
...
    470 static __inline__ int ffs(int x)
    471 {
    472         int r;
    473 
    474         __asm__("bsfl %1,%0\n\t"
    475                 "cmovzl %2,%0"
    476                 : "=r" (r) : "g" (x), "r" (32));
    477         return r+1;
    478 }

I am changing line 476 to :"=r" (r) : "rm" (x), "r" (-1));
I will post the results ASAP.

thanks,

Tru