xfs
[Top] [All Lists]

[Bug 346] New: Fix for xfs_fsr crash on DEC Alpha

To: xfs-master@xxxxxxxxxxx
Subject: [Bug 346] New: Fix for xfs_fsr crash on DEC Alpha
From: bugzilla-daemon@xxxxxxxxxxx
Date: Thu, 15 Jul 2004 04:23:43 -0700
Sender: linux-xfs-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=346

           Summary: Fix for xfs_fsr crash on DEC Alpha
           Product: Linux XFS
           Version: 1.3.x
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: xfsdump
        AssignedTo: xfs-master@xxxxxxxxxxx
        ReportedBy: jan-jaap.vanderheijden@xxxxxxxxxxxxx


In xfs_fsr.c, the function xfs_bulkstat() takes a size_t 
*ocount, but writes only to the lower 32bits: bulkreq.ocount =  (__s32 *)ocount;

When size_t is 64bits (such as on the Alpha), the upper 32bits will be undefined
. When fsrfs() passes an uninitialized variable to it, it crashes.

This is a fix against xfsdump-2.2.21:

--- xfsdump-2.2.21/fsr/xfs_fsr.c.orig   2004-07-15 12:35:29.000000000 +0200
+++ xfsdump-2.2.21/fsr/xfs_fsr.c        2004-07-15 13:19:43.000000000 +0200
@@ -178,6 +178,7 @@
 {
     xfs_fsop_bulkreq_t  bulkreq;
     
+    *ocount = 0;
     bulkreq.lastip = lastip;
     bulkreq.icount = icount;
     bulkreq.ubuffer = ubuffer;



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>
  • [Bug 346] New: Fix for xfs_fsr crash on DEC Alpha, bugzilla-daemon <=