xfs
[Top] [All Lists]

Re: [PATCH] Fix XFS uses of plain integer as NULL pointer

To: "Petri T. Koistinen" <petri.koistinen@xxxxxx>
Subject: Re: [PATCH] Fix XFS uses of plain integer as NULL pointer
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Sun, 11 Jul 2004 11:45:03 -0700
Cc: xfs-masters@xxxxxxxxxxx, nathans@xxxxxxx, linux-xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0407111343260.1846@dsl-prvgw1cc4.dial.inet.fi>
References: <Pine.LNX.4.58.0407111343260.1846@dsl-prvgw1cc4.dial.inet.fi>
Sender: linux-xfs-bounce@xxxxxxxxxxx
On Sun, Jul 11, 2004 at 01:54:09PM +0300, Petri T. Koistinen wrote:

> This patch will fix XFS sparse warnings about using plain integer as
> NULL pointer.

These are already in the CVS tree.


rom owner-linux-xfs@xxxxxxxxxxx Mon Jul 12 08:13:48 2004
Received: with ECARTIS (v1.0.0; list linux-xfs); Mon, 12 Jul 2004 08:13:59 
-0700 (PDT)
Received: from snark.thyrsus.com (dsl092-053-140.phl1.dsl.speakeasy.net 
[66.92.53.140])
        by oss.sgi.com (8.12.10/8.12.9) with SMTP id i6CFDRgi008848
        for <linux-xfs@xxxxxxxxxxx>; Mon, 12 Jul 2004 08:13:48 -0700
Received: from snark.thyrsus.com (localhost [127.0.0.1])
        by snark.thyrsus.com (8.12.11/8.12.11) with ESMTP id i6CFD1JB016921
        for <linux-xfs@xxxxxxxxxxx>; Mon, 12 Jul 2004 11:13:01 -0400
Date: Mon, 12 Jul 2004 11:13:01 -0400
From: esr@xxxxxxxxxxx
Message-Id: <200407121513.i6CFD1JB016921@xxxxxxxxxxxxxxxxx>
To: linux-xfs@xxxxxxxxxxx
Subject: problems in one or more man pages you maintain
X-archive-position: 3632
X-ecartis-version: Ecartis v1.0.0
Sender: linux-xfs-bounce@xxxxxxxxxxx
Errors-to: linux-xfs-bounce@xxxxxxxxxxx
X-original-sender: esr@xxxxxxxxxxx
Precedence: bulk
X-list: linux-xfs

This is automatically generated email about problems in a man page for which
you appear to be responsible.  If you are not the right person or list, tell
me and I will attempt to correct my database.

See http://catb.org/~esr/doclifter/problems.html for details on how and
why these patches were generated.  Feel free to email me with any questions.

Note: This patch does not change the mod date of the manual page.  You
may wish to do that by hand.

Problems with xfs_bmap.8:

1. Unknown or invalid macro.  That is, one that does not fit in the
macro set that the man page seems to be using.  This is a serious
error; it often means part of your text is being lost or rendered
incorrectly.

--- xfs_bmap.8-orig     2004-07-09 06:59:14.210997800 -0400
+++ xfs_bmap.8  2004-07-09 06:59:59.299143360 -0400
@@ -12,10 +12,12 @@
 in the file that do not have any corresponding blocks (\f2hole\f1s).
 Each line of the listings takes the following form:
 
-.Ex
-\f2extent\f1\f7: [\f1\f2startoffset\f1\f7..\f1\f2endoffset\f1\f7]: \c
-\f1\f2startblock\f1\f7..\f1\f2endblock\f1
-.Ee
+.nf
+.ft CW
+    \f2extent\f1\f7: [\f1\f2startoffset\f1\f7..\f1\f2endoffset\f1\f7]: \c
+    \f1\f2startblock\f1\f7..\f1\f2endblock\f1
+.ft
+.fi
 
 Holes are marked by replacing the \f2startblock..endblock\f1 with \f2hole\fP.
 All the file offsets and disk blocks are in units of 512-byte blocks,
@@ -29,9 +31,11 @@
 .PP
 If the \f3-l\f1 option is used, then
 
-.Ex
-\f1\f2<nblocks>\f1\f7 \f1\f2blocks\f1\f7
-.Ee
+.nf
+.ft CW
+    \f1\f2<nblocks>\f1\f7 \f1\f2blocks\f1\f7
+.ft
+.fi
 
 will be appended to each line.  \f1\f2Nblocks\f1\f7 is the length
 of the extent described on the line in units of 512-byte blocks.
Problems with xfs_check.8:

1. Unknown or invalid macro.  That is, one that does not fit in the
macro set that the man page seems to be using.  This is a serious
error; it often means part of your text is being lost or rendered
incorrectly.

--- xfs_check.8-orig    2004-07-09 07:01:51.627066920 -0400
+++ xfs_check.8 2004-07-09 07:03:06.440693520 -0400
@@ -90,17 +90,21 @@
 rather than produce useful output.
 If the filesystem is completely corrupt, a core dump might
 be produced instead of the message
-.Ex
-\f2xxx\f1\f7 is not a valid filesystem\f1
-.Ee
+.nf
+.ft CW
+    \f2xxx\f1\f7 is not a valid filesystem\f1
+.ft
+.fi
 .PP
 If the filesystem is very large (has many files) then
 .I xfs_check
 might run out of memory.
 In this case the message
-.Ex
-out of memory
-.Ee
+.nf
+.ft CW
+    out of memory
+.ft
+.fi
 is printed.
 .PP
 The following is a description of the most likely problems and the associated

--
                             Eric S. Raymond


<Prev in Thread] Current Thread [Next in Thread>