xfs
[Top] [All Lists]

[Bug 328] freeze on XFS recovery on sparc64 with linux kernel 2.4.26

To: xfs-master@xxxxxxxxxxx
Subject: [Bug 328] freeze on XFS recovery on sparc64 with linux kernel 2.4.26
From: bugzilla-daemon@xxxxxxxxxxx
Date: Sat, 15 May 2004 05:36:27 -0700
Sender: linux-xfs-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=328





------- Additional Comments From nboullis@xxxxxxxxxx  2004-15-05 05:33 PDT 
-------
Created an attachment (id=120)
 --> (http://oss.sgi.com/bugzilla/attachment.cgi?id=120&action=view)
A patch to fix XFS recovery on 64-bit little-endian architectures (like
sparc64)

As it is currently written, the xfs_contig_bits function in xfs_bit.c, when
BITS_PER_LONG != 32, implicitely assumes that the arch is little-endian, as it
considers that the LSB of *((uint *)map) is the same as the LSB of *((unsigned
long int *)map).

This patch implements a rewrite of xfs_contig_bits, that is supposed to work on
all arches. Moreover, it adds two ASSERTs that would have been useful to track
this bug.

------- Additional Comments From nboullis@xxxxxxxxxx  2004-15-05 05:35 PDT 
-------
Created an attachment (id=121)
 --> (http://oss.sgi.com/bugzilla/attachment.cgi?id=121&action=view)
A patch to fix XFS recovery on 64-bit little-endian architectures (like
sparc64)

As it is currently written, the xfs_contig_bits function in xfs_bit.c, when
BITS_PER_LONG != 32, implicitely assumes that the arch is little-endian, as it
considers that the LSB of *((uint *)map) is the same as the LSB of *((unsigned
long int *)map).

This patch implements a rewrite of xfs_contig_bits, that is supposed to work on
all arches. Moreover, it adds two ASSERTs that would have been useful to track
this bug.

------- Additional Comments From nboullis@xxxxxxxxxx  2004-15-05 05:36 PDT 
-------
(From update of attachment 121)
As it is currently written, the xfs_contig_bits function in xfs_bit.c, when
BITS_PER_LONG != 32, implicitely assumes that the arch is little-endian, as it
considers that the LSB of *((uint *)map) is the same as the LSB of *((unsigned
long int *)map).

This patch implements a rewrite of xfs_contig_bits, that is supposed to work on
all arches. Moreover, it adds two ASSERTs that would have been useful to track
this bug.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>