xfs
[Top] [All Lists]

[Bug 320] xfsinvutil -i crash with segfault

To: xfs-master@xxxxxxxxxxx
Subject: [Bug 320] xfsinvutil -i crash with segfault
From: bugzilla-daemon@xxxxxxxxxxx
Date: Fri, 26 Mar 2004 01:16:00 -0800
Sender: linux-xfs-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=320


tes@xxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112 is|0                           |1
           obsolete|                            |




------- Additional Comments From tes@xxxxxxx  2004-26-03 01:13 PDT -------
Created an attachment (id=114)
 --> (http://oss.sgi.com/bugzilla/attachment.cgi?id=114&action=view)
xfsinvutil segv fix attempt#2

Looks like xfsdump/invutil/stobj.c on line 432 may be not
allocating a big enough txt string.
It would be nicer to use snprintf() here and perhaps use
a string length which is more accurate based on the
length of session->session->s_label and a macro constant for the rest of the
string.....but for now keep it simple.

------- Additional Comments From tes@xxxxxxx  2004-26-03 01:15 PDT -------
Looks like xfsdump/invutil/stobj.c on line 432 may be not
allocating a big enough txt string.
It would be nicer to use snprintf() here and perhaps use
a string length which is more accurate based on the
length of session->session->s_label and a macro constant for the rest of the
string.....but for now
can you just try making
    432         txt = malloc(60);
to something bigger, say:
    432         txt = malloc(60+strlen(session->session->s_label));
and see if that helps.
I've attached patch.....I'm new to bugzilla...

--Tim



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>