xfs
[Top] [All Lists]

TAKE - xlog_verify_iclog()

To: linux-xfs@xxxxxxxxxxx
Subject: TAKE - xlog_verify_iclog()
From: Timothy Shimmin <tes@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 19 Aug 2003 17:38:20 +1000 (EST)
Sender: linux-xfs-bounce@xxxxxxxxxxx
Hopefully help with the xlog_verify_iclog() assertion failures
that Nathan saw with v2 logs.

--Tim

pv=892598; rv=nathans@xxxxxxx;
Change xlog_verify_iclog() to use idx as zero based instead
of 1 based index into array. 
Nathan tried this change out on some benchmarks and it seems 
to help - stop the assert from happening.
Nathan will do the merge of this mod.

Date:  Tue Aug 19 00:33:49 PDT 2003
Workarea:  snort.melbourne.sgi.com:/home/tes/isms/slinx-xfs

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  xfs-linux:slinx:156160a
linux/fs/xfs/xfs_log.c - 1.280
        - Change xlog_verify_iclog() to use idx as zero based instead
          of 1 based index into array. To do this use BTOBBT() instead
          of BTOBB() to work out which page (starting from zero) that
          we are on. This then requires idx comparison to be altered
          from > to >= (as was initially used in Glen's IRIX change).
          The change is needed for extraction of the oh_clientid and oh_len 
fields.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE - xlog_verify_iclog(), Timothy Shimmin <=