| To: | torvalds@xxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] fix kmem_cache_size() for new slab poisoning |
| From: | Christoph Hellwig <hch@xxxxxxx> |
| Date: | Tue, 11 Mar 2003 16:59:23 -0500 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxxx>, torvalds@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx |
| Sender: | linux-xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5.1i |
The new slab poisoning code broke kmem_cache_size(), it now returns
a too large size as the poisoning area after the object is includes.
XFS's kmem_zone_zalloc thus overwrites exactly that area and triggers
the new checks everytime such an object is freed again.
I don't recommend using XFS on BK-current without this patch applied :)
--- 1.68/mm/slab.c Sat Mar 8 23:50:36 2003
+++ edited/mm/slab.c Tue Mar 11 15:15:44 2003
@@ -2041,11 +2041,16 @@
unsigned int kmem_cache_size(kmem_cache_t *cachep)
{
+ unsigned int objlen = cachep->objsize;
+
#if DEBUG
if (cachep->flags & SLAB_RED_ZONE)
- return (cachep->objsize - 2*BYTES_PER_WORD);
+ objlen -= 2*BYTES_PER_WORD;
+ if (cachep->flags & SLAB_STORE_USER)
+ objlen -= BYTES_PER_WORD;
#endif
- return cachep->objsize;
+
+ return objlen;
}
kmem_cache_t * kmem_find_general_cachep (size_t size, int gfpflags)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Bug 229] xfs_repair unable to repair system, bugzilla-daemon |
|---|---|
| Next by Date: | RE: TAKE - pagebuf, HABBINGA,ERIK (HP-Loveland,ex1) |
| Previous by Thread: | TAKE - bhv code cleanup, Nathan Scott |
| Next by Thread: | mount options..., l.a walsh |
| Indexes: | [Date] [Thread] [Top] [All Lists] |