Re: fix 2.4-xfs pagebuf request

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Sun, Oct 27, 2002 at 04:13:51PM +0900, ASANO Masahiro wrote:
> Hi,
> 
> I found a bug at current 2.4 CVS about `struct pagesync_t'.
> Some driver top-half may call buffer_head.b_end_io() on process
> context (not interrupt context). So _end_pagebuf_page_io_multi() may
> be called several times with remain==1.

Thanks for the patch.  Luben, I think this patch will fix your
lvm+raid setup, could you try it?

> --- linux/fs/xfs/pagebuf/page_buf.c   Fri Oct 25 07:46:20 2002
> +++ linux/fs/xfs/pagebuf/page_buf.c.new       Sun Oct 27 15:53:38 2002
> @@ -1645,7 +1645,7 @@
>                               BUG();  /* Ugh - out of memory condition here */
>                       psync->pb = pb;
>                       psync->locking = locking;
> -                     atomic_set(&psync->remain, 0);
> +                     atomic_set(&psync->remain, cnt);
>  
>                       callback = public_bh ?
>                                  _end_io_multi_part : _end_io_multi_full;
> @@ -1667,7 +1667,6 @@
>                       /* Complete the buffer_head, then submit the IO */
>                       if (psync) {
>                               init_buffer(bh, callback, psync);
> -                             atomic_inc(&psync->remain);
>                       } else {
>                               init_buffer(bh, callback, pb);
>                       }
> 
>