xfs
[Top] [All Lists]

[Bug 184] xfs_force_shutdown called on lvm-snapshot

To: xfs-master@xxxxxxxxxxx
Subject: [Bug 184] xfs_force_shutdown called on lvm-snapshot
From: bugzilla-daemon@xxxxxxxxxxx
Date: Tue, 22 Oct 2002 21:20:36 -0700
Sender: linux-xfs-bounce@xxxxxxxxxxx
http://oss.sgi.com/bugzilla/show_bug.cgi?id=184





------- Additional Comments From sandeen@xxxxxxx  2002-10-22 21:20 -------
Ok, here's what's going on.  Erik had some files with "left-over"
preallocation on the files, probably the result of some crash or other.
(xfs pre-allocates space, but normally removes it when the file is closed).

So, xfs was trying to clean up this pre-allocated space when the file
in the snapshot was closed, but it was a read-only device, the I/O failed,
and xfs shut down.

The attached patch checks the VFS_RDONLY patch before calling
xfs_inactive_free_eofblocks, and doesn't do it if the flag is present.
This has the effect of leaving these blocks past EOF, but that's better than
a shutdown, and it can be cleaned up when the fs is mounted read-write again.

This also toggles the VFS_RDONLY flag -off- before doing recovery on a 
read-only mount, so that recovery can still do what it needs to do, as long 
as the underlying device is not read-only.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


<Prev in Thread] Current Thread [Next in Thread>