xfs
[Top] [All Lists]

Re: [2.4.18-14SGI_XFS_1.2a1] acl problems

To: linux-xfs@xxxxxxxxxxx
Subject: Re: [2.4.18-14SGI_XFS_1.2a1] acl problems
From: Axel Thimm <Axel.Thimm@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 13 Oct 2002 05:59:29 +0200
In-reply-to: <20021012204316.GP13549@plato.local.lan> <20021012153026.GA17332@bonzo.nirvana>
References: <1034370565.14233.33.camel@stout.americas.sgi.com> <20021012153026.GA17332@bonzo.nirvana> <20021012204316.GP13549@plato.local.lan> <20021011010713.GA4254@bonzo.nirvana> <20021011014047.GA27651@tapu.f00f.org> <20021011020437.GA1144622@down.physik.fu-berlin.de> <20021011211538.GA27574@sgi.com> <20021011010713.GA4254@bonzo.nirvana> <1034370565.14233.33.camel@stout.americas.sgi.com> <20021012153026.GA17332@bonzo.nirvana>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
On Sat, Oct 12, 2002 at 05:30:26PM +0200, Axel Thimm wrote:
> # ==========> what packages are there? Check them
> Fri Aug 23 20:01:11 UTC 2002 astest   bash-2.05b-5
> Thu Aug 29 20:56:33 UTC 2002 stripples.devel.redhat.com       
> sh-utils-2.0.12-3
> Mon Sep  2 11:21:27 UTC 2002 daffy.perf.redhat.com    fileutils-4.1.9-11
> Thu Sep  5 23:12:33 UTC 2002 daffy.perf.redhat.com    glibc-2.2.93-5
> Tue Oct  1 18:44:14 UTC 2002 stout.americas.sgi.com   attr-2.0.11-0
> Tue Oct  1 18:44:14 UTC 2002 stout.americas.sgi.com   attr-devel-2.0.11-0
> Tue Oct  1 18:44:14 UTC 2002 stout.americas.sgi.com   libattr-2.0.11-0
> Tue Oct  1 18:45:14 UTC 2002 stout.americas.sgi.com   acl-2.0.19-0
> Tue Oct  1 18:45:14 UTC 2002 stout.americas.sgi.com   acl-devel-2.0.19-0
> Tue Oct  1 18:45:14 UTC 2002 stout.americas.sgi.com   libacl-2.0.19-0

I just found out, that I was using the rpms from
http://oss.sgi.com/projects/xfs/download/cmd_rpms instead of the ones in
1.2pre1. But switching to them does not make any difference.

On Sat, Oct 12, 2002 at 12:43:16PM -0800, Ethan Benson wrote:
> On Sat, Oct 12, 2002 at 05:30:26PM +0200, Axel Thimm wrote:
> > The bug seems to be in the acl parts and is not restricted to root
> > XFS-partitions [...]
> 
> yes this is exceedingly annoying since acl aware ls shows such files
> with a + on the permissions, which is erroneous.
> 
> you can see the acls with the following:
> 
> getfattr -m . file
> 
> you will see a system.posix_acl_access attribute (system.* is not
> displayed by default).

I also see a xfsroot.SGI_ACL_FILE entry.

> you can remove them with:
> setfattr -x system.posix_acl_access file

Which also removes the xfsroot.SGI_ACL_FILE entry (as it should, I guess).

> can you try this test by removing the acl with the above setfattr
> command instead of setfacl (which seems to be partly broken in regards
> to acl removal) 

Yes, it works as you describe it. Thanks, it works better for restoring my
files then copying them back and forth with non-acl aware tools (like local
rsync).

So there are three bugs?
a) XFS code should automatically remove ACL attributes if not needed anymore.
b) same for setfacl.
c) files with ACLs appear as executable for root.

If a) is not done in the kernel but in the userland, then maybe a) & b) are
the same bug.
-- 
Axel.Thimm@xxxxxxxxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>