xfs
[Top] [All Lists]

Re: [2.4.18-14SGI_XFS_1.2a1] acl problems (was: root xfs filesystem exec

To: Eric Sandeen <sandeen@xxxxxxx>, Chris Wedgwood <cw@xxxxxxxx>, linux-xfs@xxxxxxxxxxx, David Greaves <david@xxxxxxxxxxxx>
Subject: Re: [2.4.18-14SGI_XFS_1.2a1] acl problems (was: root xfs filesystem executable bits bug comeback?)
From: Axel Thimm <Axel.Thimm@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 12 Oct 2002 17:30:26 +0200
In-reply-to: <20021011211538.GA27574@sgi.com> <1034370565.14233.33.camel@stout.americas.sgi.com>
References: <20021011010713.GA4254@bonzo.nirvana> <20021011014047.GA27651@tapu.f00f.org> <20021011020437.GA1144622@down.physik.fu-berlin.de> <20021011211538.GA27574@sgi.com> <20021011010713.GA4254@bonzo.nirvana> <1034370565.14233.33.camel@stout.americas.sgi.com>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
The bug seems to be in the acl parts and is not restricted to root
XFS-partitions (Eric, sorry for my bad wording about "root-mounted" partitions
in the previous mail).

It is also difficult to trigger - creating files is fine, copying them with
"cp -p" to a XFS-partition (src is not relevant) is creating an (empty?) acl
entry, which "test -x" misinterpretes if you are root (these acls also cannot
be removed with setfacl -b and setfacl -k, and are also not diplayed with
getfacl or getfattr).

In general the bugs seem to be described as:
o acl aware applications like "cp -p" create empty unremovable acls (or set
  some acl-is-here flag without truly holding an acl).
o files with acls (empty or not) are always interpreted to have te permission
  flag set if you are root.

Attached is a small test-case script as well as the output on my system (for
root and a non-root user). Finally I also included a run on an older system
(RH7.2 & XFS from april).

Could you try the test case on your systems?

BTW there is a small name clash between vanilla RedHat and SGI provided acl
rpms: What SGI calls acl-devel, RedHat decided to call libacl-devel. But I
think this is only a package dependency problem (the XFS acl-devel should
obsolete libacl-devel or should adjust the name).

On Fri, Oct 11, 2002 at 04:09:25PM -0500, Eric Sandeen wrote:
> On Thu, 2002-10-10 at 20:07, Axel Thimm wrote:
> > The bug fixed in
> > http://marc.theaimsgroup.com/?l=linux-xfs&m=103001217021455&w=2
> > seems to have come back. An XFS root mounted partition returns always true 
> > on
> > all files with "test -x". Non-root mounted XFS partitions are OK.

As mentioned above "all files" is wrong (I had copied away and back the root
partition while setting up the system, therefore all files had "empty" acls),
as well as "only root partitions" (on the others I just tested "touch").

> I'll look at this one, since I fixed it last time...  Are you running
> this on a Red Hat 8.0 system?  Also, by "root-mounted" you mean the root
> filesystem, I guess?  (i.e. "/"?)

On Fri, Oct 11, 2002 at 04:15:39PM -0500, Nathan Straz wrote:
> > > What kernel version(s)?
> > The one mentioned in the subject, which is the prerelease version for
> > SGI_XFS_1.2. 
> 
> I don't see this bug with the version in the subject.
> [root@tarpon tmp]# df -Th .
> Filesystem    Type    Size  Used Avail Use% Mounted on
> /dev/sda6      xfs    3.6G  909M  2.7G  25% /
> [root@tarpon tmp]# uname -r
> 2.4.18-14SGI_XFS_1.2a1
> [root@tarpon tmp]# touch newfile
> [root@tarpon tmp]# chmod -x newfile
> [root@tarpon tmp]# test -x newfile && echo xxx
> [root@tarpon tmp]# chmod +x newfile
> [root@tarpon tmp]# test -x newfile && echo xxx
> xxx
> [root@tarpon tmp]# rpm -q bash
> bash-2.05b-5
> 
> Can you double check your kernel version and bash version?

The system is what (I think) you would get from a custom->everything install
of the SGI-XFS RedHat installer (I installed custom->minimal and included the
rest by hand afterwards).
-- 
Axel.Thimm@xxxxxxxxxxxxxxxxxxx

Attachment: test-xfs-acl.sh
Description: Bourne shell script

Attachment: test-xfs-acl-as-root.log
Description: Text document

Attachment: test-xfs-acl-as-non-priviledged-user.log
Description: Text document

Attachment: test-xfs-acl-as-root-on-older-system.log
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>