xfs
[Top] [All Lists]

TAKE 864048 - Allow non-root to set sticky bit on regular files

Subject: TAKE 864048 - Allow non-root to set sticky bit on regular files
From: Eric Sandeen <sandeen@xxxxxxx>
Date: Mon, 12 Aug 2002 15:16:40 -0500
Sender: owner-linux-xfs@xxxxxxxxxxx
The LTP test "chmod03" was failing here, when xfs disallowed setting
the sticky bit on a regular file by a non-root user.  This was
specifically disallowed in xfs_setattr; back in the XFS 1.1 days
it wasn't apparent because we subsequently called inode_setattr,
which allowed it.

We no longer call inode_setattr in linvfs_setattr, and rather call
vn_revalidate against the xfs inode, and the cleared sticky bit
made it to the "outside world"

This change just #if's out the part of the code that
disallowed setting the sticky bit and keeps the code there for 
reference on the difference from Irix behavior...

Date:  Mon Aug 12 13:17:49 PDT 2002
Workarea:  
stout.americas.sgi.com:/localhome/src/sandeen/2.4.x-xfs/workarea-alwaysclean

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  2.4.x-xfs:slinx:124838a
linux/fs/xfs/xfs_vnodeops.c - 1.550
        - Allow non-root to set sticky bit on regular files.
          (Linux difference from Irix, apparently).



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 864048 - Allow non-root to set sticky bit on regular files, Eric Sandeen <=