Re: TAKE - 1 step closer to removing -funsigned-char

[utz lehmann <xfs@xxxxxxxxxx>]

Hi Eric

Eric Sandeen [sandeen@xxxxxxx] wrote:
> XFS on Irix gets to assume chars are unsigned, which is not true
> on Linux, so we use the -funsigned-char option when we build it.
> Getting rid of this would be nice; we can explicitly define unsigned
> chars when we need them.  The trick is figuring out when we need them.  :)
> 
> These changes should fix the international character problems some were
> seeing when -funsigned-char was turned off; if some of those brave souls
> could turn off -funsigned-char on their machines and give it another go,
> reports of success or failure would be welcome.  :)

Ok, here is my report of success.-)

I wrote a perl script that touches 96 files. Each file begins with a
different 8bit character (160 - 255) and have a random filename length.

I removed -funsigned-char from linux/fs/xfs/Makefile and
linux/fs/xfs/linux/Makefile.

I created files with 2.4.9 and checkt it with 2.4.17 and vice versa.
"ls -l" and removing works. No Problems.


utz


Here is the script:

foreach $c0 (0 .. 95) {
        $f = "";
        foreach $c1 ($c0 .. ($c0 + int( rand(17) + 5))) {
                $c = ($c1 % 96) + 160;
                $f .= sprintf("%c", $c);
        }
#       print "$f\n";
        system ("touch $f");
}