Thanks for these, I will be putting them into the tree today sometime.
Steve
> For XFS 1.0.1 release:
> In file fs/xfs/xfs_mount.c, there seems to be some bugs with error
> handling.
>
> First, around line 851 and 870, the following code should be added
> rvp->v_flag |= VPURGE;
> before calling
> vn_purge(rvp, &vmap);
>
> Second, the exit of error2 should add some code to free the log structure.
> eg.
> xfs_log_unmount_dealloc(mp)
> for some error cases after the log structure is allocated.
>
> Third, if it exits from line 840, ( "fail to read root inode") , the next
> mount
> will Oops. I've looked at the code but didn't find any obvious errors,
> maybe
> someone can check it for more details. Probably there are some problems
> with xfs_iget at error handling.
>
> Best Regards,
> Harrison Xing
>
>
> _________________________________________________________________
> Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp
|