xfs
[Top] [All Lists]

xfs_repair wipes ACL entries, maybe endian-related?

To: linux-xfs@xxxxxxxxxxx
Subject: xfs_repair wipes ACL entries, maybe endian-related?
From: KELEMEN Peter <fuji@xxxxxxx>
Date: Fri, 23 Mar 2001 20:11:37 +0100
Organization: ELTE Eotvos Lorand University of Sciences, Budapest, Hungary
Reply-to: KELEMEN Peter <fuji@xxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hello,

[ I have no access to the test machine, I'm writing from my memory ]

I've been peeking at ACLs today (CVS tree as of 2001/03/22 ~16:00
CET).  After setting the ACL on a file, unmounting the filesystem
and running xfs_repair, it intends to wipe out the ACL entries.
Looking at the code, xfsprogs/repair/attr_repair.c::valid_acl()
decides it should be cleared.  Reason: acl_cnt > MAX_ACL_ENTRIES,
I sniffed around with xfs_db, SGI_ACL_FILE attr with 304 byte
value is OK, in my case it was \000\000\000\005... (normal u,g,o
plus one u and a mask); valid_acl thinks that acl_cnt is 83886080,
which just happens to be 0x5000000.  I somehow suspect that adding
some INT_GET(..., ARCH_CONVERT) macros around the obvious places
in valid_acl() is not The Right Thing To Do(tm), hence no patch.

Peter

-- 
    .+'''+.         .+'''+.         .+'''+.         .+'''+.         .+''
 Kelemen Péter     /       \       /       \       /      fuji@xxxxxxx
.+'         `+...+'         `+...+'         `+...+'         `+...+'

<Prev in Thread] Current Thread [Next in Thread>