xfs
[Top] [All Lists]

TAKE 801764 - xfs_check and xfs_repair should fail if device mounted

To: nathans@xxxxxxxxxxxxxxxxxxxx
Subject: TAKE 801764 - xfs_check and xfs_repair should fail if device mounted
From: pv@xxxxxxxxxxxxxxxxxxxxxx (nathans@xxxxxxxxxxxx)
Date: Mon, 25 Sep 2000 21:55:03 -0700 (PDT)
Cc: linux-xfs@xxxxxxxxxxx
Reply-to: sgi.bugs.xfs@xxxxxxxxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
 Submitter : dxm                      *Status : closed                      
 Assigned Engineer : nathans          *Fixed By : nathans                   
*Fixed By Domain : engr               *Closed Date : 09/25/00               
 Priority : 4                         *Modified Date : 09/25/00             
*Modified User : nathans              *Modified User Domain : engr          
*Fix Description :
From: nathan scott <nathans@xxxxxxxxxxxxxxxxxxxxxxx> (TAKE)
Date: Sep 17 2000 10:15:04PM
[pvnews version: 1.71]
----------------------------

Got the green light for this to go into beta.  Also rolled
the version number for xfs-cmds to 1.0.5 for official beta.

Modid:  2.4.0-test1-xfs:slinx:74557a
Date:  Sun Sep 17 22:09:48 PDT 2000

.....


==========================
ADDITIONAL INFORMATION (TAKE)
From: nathan scott <nathans@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sep 25 2000 09:55:03PM
[pvnews version: 1.71]
==========================
Modid:  2.4.x-xfs:slinx:75011a
Date:  Mon Sep 25 21:51:06 PDT 2000
Workarea:  snort:/build4/nathans/base-linux-xfs
Author:  nathans

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs

cmd/xfs/db/init.c - 1.29
cmd/xfs/db/xfs_check.sh - 1.7
cmd/xfs/db/xfs_check64.sh - 1.5
cmd/xfs/include/libxfs.h - 1.18
cmd/xfs/libxfs/init.c - 1.13
cmd/xfs/logprint/logprint.c - 1.49
cmd/xfs/repair/init.c - 1.15
        - where it matters, allow tools to specify whether a filesystem may be
          mounted, mounted ro, or mounted rw before starting - different tools
          have different needs.  new isinactive flag to libxfs, in combination
          with existing isreadonly, provides this functionality.
Description :
both "xfs_check" and "xfs_repair -n" may be run on a mounted
filesystem and will usually produce lots of warnings about
filesystem corruption due to the inconsistent state the FS
is in.

Both tools should fail or at least warn that the FS is mounted
before proceeding. 

xfs_logprint should also warn when run on a mounted FS, but
can still be useful when mounted.

.....


==========================
ADDITIONAL INFORMATION (REOPEN)
From: nathans@engr (BugWorks)
Date: Sep 17 2000 11:09:28PM
==========================

I've backed this fix out... it works but is too simplistic an
approach for the general case.  We should allow these tools to
run on a filesystem which is mounted read-only - this change
currently disallows _all_ mounted filesystems, which is too
strict.

<Prev in Thread] Current Thread [Next in Thread>