| To: | "Christoph Hellwig" <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [PATCH, updated] xfs: Ensure we force all busy extents inrange to disk |
| From: | "Alex Elder" <aelder@xxxxxxx> |
| Date: | Sun, 10 Jan 2010 12:28:08 -0600 |
| Cc: | "Dave Chinner" <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20100109193514.GA12372@xxxxxxxxxxxxx> |
| Thread-index: | AcqRYu8jG7bNmp6bSoOMFdFy2teLDQAr7Z3w |
| Thread-topic: | [PATCH, updated] xfs: Ensure we force all busy extents inrange to disk |
Christoph Hellwig wrote:
> Looks good,
Thanks, I will publish this today.
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
>> TRACE_EVENT(xfs_alloc_busysearch,
>> TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno,
>> - xfs_extlen_t len, int found),
>> - TP_ARGS(mp, agno, agbno, len, found),
>> + xfs_extlen_t len, int found, xfs_lsn_t lsn),
>> + TP_ARGS(mp, agno, agbno, len, found, lsn),
>
> The found argument to this tracepoint can be dropped - with the new loop
> style it doesn't work anymore, and a non-zero lsn provides the same
> information.
I agree with that, and have now removed that argument
from the tracepoint, with the net effect that the lsn
argument simply replaces it.
-Alex
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [XFS updates] XFS development tree branch, master, updated. v2.6.30-rc4-34429-g153f0ca, xfs |
|---|---|
| Next by Date: | [XFS updates] XFS development tree branch, for-linus, updated. v2.6.30-rc4-34575-gfd45e478, xfs |
| Previous by Thread: | Re: [PATCH, updated] xfs: Ensure we force all busy extents in range to disk, Christoph Hellwig |
| Next by Thread: | [PATCH] XFS: Use list_heads for log recovery item lists, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |