xfs
[Top] [All Lists]

Re: [PATCH 02/14] fs: introduce iomap infrastructure

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 02/14] fs: introduce iomap infrastructure
From: Bob Peterson <rpeterso@xxxxxxxxxx>
Date: Thu, 5 May 2016 13:32:08 -0400 (EDT)
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1462310947-16132-3-git-send-email-hch@xxxxxx>
References: <1462310947-16132-1-git-send-email-hch@xxxxxx> <1462310947-16132-3-git-send-email-hch@xxxxxx>
Thread-index: ewnX9LC7GAmhZHyrwn1uk5nUue1LyA==
Thread-topic: introduce iomap infrastructure
----- Original Message -----
> Add infrastructure for multipage buffered writes.  This is implemented
> using an main iterator that applies an actor function to a range that
> can be written.
> 
> This infrastucture is used to implement a buffered write helper, one
> to zero file ranges and one to implement the ->page_mkwrite VM
> operations.  All of them borrow a fair amount of code from fs/buffers.
> for now by using an internal version of __block_write_begin that
> gets passed an iomap and builds the corresponding buffer head.
> 
> The file system is gets a set of paired ->iomap_begin and ->iomap_end
> calls which allow it to map/reserve a range and get a notification
> once the write code is finished with it.
> 
> Based on earlier code from Dave Chinner.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> +             /*
> +              * For unwritten regions, we always need to ensure that
> +              * sub-block writes cause the regions in the block we are not
> +              * writing to are zeroed. Set the buffer as new to ensre this.

Minor typo: s/ensre/ensure/ above.

Reviewed-off-by: Bob Peterson <rpeterso@xxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>