xfs
[Top] [All Lists]

[PATCH] xfs_io: implement 'utimes' command

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs_io: implement 'utimes' command
From: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
Date: Sat, 17 Dec 2016 17:11:45 -0800
Cc: arnd@xxxxxxxx, y2038@xxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=V+Q6D2bYRTCyfxrOhaUSEHY1IYfgiPEZskzks93GYew=; b=q4lBizISayPRxrJS1dKNYAIeqtIK6E3UBWET3wRQlmbsEGbAtIy08PUMXADJg87zUj b13NYE2hC1iMNQ+5681ZMRgcSzZfY5b6picylOdmkgSlRcrdsooXmGJCXJ8LAkNbZgRv F+LjtNbnQzg48O+l9Sy64y31Q9/hZzHsbFOe/TKJet/561o/YqJXrFrTt5UA2Z86RzQ6 AzAdwX+WvFvTEW0kx+fc5yDEXj9qlotpNoq+iPoatSECbhV1CMMrQh8bEThXH3fU0yR6 JaWHc5Nm004f6IMu+SzfDa36pFolA82y8r3RZBEYdCVwLXyu98ZJXq1X9eoJqw1sN3ev qR5w==
Add the utimes command to provide a way to utilize
the futimens C library call. On linux, this is the
interface to the utimensat system call, which updates
the mtime and atime of a file.

Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
---
 include/input.h |  1 +
 io/Makefile     |  2 +-
 io/init.c       |  1 +
 io/io.h         |  1 +
 io/utimes.c     | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 libxcmd/input.c | 22 +++++++++++++++
 6 files changed, 109 insertions(+), 1 deletion(-)
 create mode 100644 io/utimes.c

diff --git a/include/input.h b/include/input.h
index d02170f..221678e 100644
--- a/include/input.h
+++ b/include/input.h
@@ -48,6 +48,7 @@ extern uid_t  uid_from_string(char *user);
 extern gid_t   gid_from_string(char *group);
 extern prid_t  prid_from_string(char *project);
 extern bool    isdigits_only(const char *str);
+extern int     timespec_from_string(const char *sec, const char *nsec, struct 
timespec *ts);
 
 #define HAVE_FTW_H 1   /* TODO: configure me */
 
diff --git a/io/Makefile b/io/Makefile
index 62bc03b..392e02a 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -11,7 +11,7 @@ HFILES = init.h io.h
 CFILES = init.c \
        attr.c bmap.c file.c freeze.c fsync.c getrusage.c imap.c link.c \
        mmap.c open.c parent.c pread.c prealloc.c pwrite.c seek.c shutdown.c \
-       sync.c truncate.c reflink.c
+       sync.c truncate.c reflink.c utimes.c
 
 LLDLIBS = $(LIBXCMD) $(LIBHANDLE)
 LTDEPENDENCIES = $(LIBXCMD) $(LIBHANDLE)
diff --git a/io/init.c b/io/init.c
index efe7390..6319aeb 100644
--- a/io/init.c
+++ b/io/init.c
@@ -85,6 +85,7 @@ init_commands(void)
        sync_range_init();
        truncate_init();
        reflink_init();
+       utimes_init();
 }
 
 static int
diff --git a/io/io.h b/io/io.h
index 2bc7ac4..fddd7a3 100644
--- a/io/io.h
+++ b/io/io.h
@@ -113,6 +113,7 @@ extern void         seek_init(void);
 extern void            shutdown_init(void);
 extern void            sync_init(void);
 extern void            truncate_init(void);
+extern void            utimes_init(void);
 
 #ifdef HAVE_FADVISE
 extern void            fadvise_init(void);
diff --git a/io/utimes.c b/io/utimes.c
new file mode 100644
index 0000000..419d221
--- /dev/null
+++ b/io/utimes.c
@@ -0,0 +1,83 @@
+/*
+ * Copyright (c) 2016 Deepa Dinamani
+ * All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include "command.h"
+#include "input.h"
+#include "init.h"
+#include "io.h"
+
+static cmdinfo_t utimes_cmd;
+
+static void
+utimes_help(void)
+{
+       printf(_(
+"\n"
+" Update file atime and mtime of the current file with nansecond precision.\n"
+"\n"
+" Usage: utimes atime.tv_sec atime.tv_nsec mtime.tv_sec mtime.tv_nsec\n"
+" Timestamp is seconds and nanoseconds since 1970-01-01 00:00:00 UTC\n"
+"\n"));
+}
+
+static int
+utimes_f(
+       int             argc,
+       char            **argv)
+{
+       struct timespec t[2];
+       int result;
+
+       if (argc != 5)
+               return command_usage(&utimes_cmd);
+
+       /* Get the timestamps */
+       result = timespec_from_string(argv[1], argv[2], &t[0]);
+       if (result) {
+               fprintf(stderr, "Bad value for atime\n");
+               return 1;
+       }
+       result = timespec_from_string(argv[3], argv[4], &t[1]);
+       if (result) {
+               fprintf(stderr, "Bad value for mtime\n");
+               return 1;
+       }
+
+       /* Call futimens to update time. */
+       if (futimens(file->fd, t)) {
+               perror("futimens");
+               return 1;
+       }
+
+       return 0;
+}
+
+void
+utimes_init(void)
+{
+       utimes_cmd.name = "utimes";
+       utimes_cmd.cfunc = utimes_f;
+       utimes_cmd.argmin = 4;
+       utimes_cmd.argmax = 4;
+       utimes_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
+       utimes_cmd.args = _("atime.tv_sec atime.tv_nsec mtime.tv_sec 
mtime.tv_nsec");
+       utimes_cmd.oneline = _("Update file times for a file");
+       utimes_cmd.help = utimes_help;
+
+       add_command(&utimes_cmd);
+}
diff --git a/libxcmd/input.c b/libxcmd/input.c
index 5a7dce3..2fdb3e8 100644
--- a/libxcmd/input.c
+++ b/libxcmd/input.c
@@ -327,6 +327,28 @@ timestr(
 }
 
 /*
+ * Convert from a pair of arbitrary user strings into a timespec.
+ */
+
+int
+timespec_from_string(
+       const char      * secs,
+       const char      * nsecs,
+       struct timespec * ts)
+{
+       char* p;
+       if (!secs || !nsecs || !ts)
+               return -1;
+       ts->tv_sec = strtoull(secs, &p, 0);
+       if (*p)
+               return -1;
+       ts->tv_nsec = strtoull(nsecs, &p, 0);
+       if (*p)
+               return -1;
+       return 0;
+}
+
+/*
  * Convert from arbitrary user strings into a numeric ID.
  * If it's all numeric, we convert that inplace, else we do
  * the name lookup, and return the found identifier.
-- 
2.7.4

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs_io: implement 'utimes' command, Deepa Dinamani <=