| To: | darrick.wong@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH] xfs: fail ->bmap for reflink inodes |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Thu, 26 May 2016 15:02:04 +0200 |
| Cc: | xfs@xxxxxxxxxxx, linux-mm@xxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1464267724-31423-1-git-send-email-hch@xxxxxx> |
| References: | <1464267724-31423-1-git-send-email-hch@xxxxxx> |
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
fs/xfs/xfs_aops.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index a955552..d053a9e 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -1829,6 +1829,17 @@ xfs_vm_bmap(
trace_xfs_vm_bmap(XFS_I(inode));
xfs_ilock(ip, XFS_IOLOCK_SHARED);
+
+ /*
+ * The swap code (ab-)uses ->bmap to get a block mapping and then
+ * bypasseѕ the file system for actual I/O. We really can't allow
+ * that on reflinks inodes, so we have to skip out here. And yes,
+ * 0 is the magic code for a bmap error..
+ */
+ if (xfs_is_reflink_inode(ip)) {
+ xfs_iunlock(ip, XFS_IOLOCK_SHARED);
+ return 0;
+ }
filemap_write_and_wait(mapping);
xfs_iunlock(ip, XFS_IOLOCK_SHARED);
return generic_block_bmap(mapping, block, xfs_get_blocks);
--
2.1.4
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: LVM snapshot and log record CRC mismatch, Emmanuel Florac |
|---|---|
| Next by Date: | oh the joy of swap files, Christoph Hellwig |
| Previous by Thread: | oh the joy of swap files, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs: fail ->bmap for reflink inodes, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |