| To: | linux-nvdimm@xxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH v7 1/6] dax: fallback from pmd to pte on error |
| From: | Vishal Verma <vishal.l.verma@xxxxxxxxx> |
| Date: | Wed, 11 May 2016 15:08:47 -0600 |
| Cc: | Dan Williams <dan.j.williams@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jens Axboe <axboe@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jeff Moyer <jmoyer@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1463000932-31680-1-git-send-email-vishal.l.verma@xxxxxxxxx> |
| References: | <1463000932-31680-1-git-send-email-vishal.l.verma@xxxxxxxxx> |
From: Dan Williams <dan.j.williams@xxxxxxxxx>
In preparation for consulting a badblocks list in pmem_direct_access(),
teach dax_pmd_fault() to fallback rather than fail immediately upon
encountering an error. The thought being that reducing the span of the
dax request may avoid the error region.
Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Jan Kara <jack@xxxxxxx>
Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
---
fs/dax.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index 9bc6624..d602410 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -855,8 +855,8 @@ int __dax_pmd_fault(struct vm_area_struct *vma, unsigned
long address,
long length = dax_map_atomic(bdev, &dax);
if (length < 0) {
- result = VM_FAULT_SIGBUS;
- goto out;
+ dax_pmd_dbg(&bh, address, "dax-error fallback");
+ goto fallback;
}
if (length < PMD_SIZE) {
dax_pmd_dbg(&bh, address, "dax-length too small");
--
2.5.5
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH v7 0/6] dax: handling media errors (clear-on-zero only), Vishal Verma |
|---|---|
| Next by Date: | [PATCH v7 3/6] dax: use sb_issue_zerout instead of calling dax_clear_sectors, Vishal Verma |
| Previous by Thread: | [PATCH v7 2/6] dax: enable dax in the presence of known media errors (badblocks), Vishal Verma |
| Next by Thread: | [PATCH v7 3/6] dax: use sb_issue_zerout instead of calling dax_clear_sectors, Vishal Verma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |