xfs
[Top] [All Lists]

[PATCH] xfs: fix a memory leak in xfs_get_acl on error

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: fix a memory leak in xfs_get_acl on error
From: Mateusz Guzik <mguzik@xxxxxxxxxx>
Date: Wed, 30 Mar 2016 16:35:07 +0200
Cc: Andreas Gruenbacher <agruenba@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Signed-off-by: Mateusz Guzik <mguzik@xxxxxxxxxx>
---
 fs/xfs/xfs_acl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
index 2dad2b5..ce10c4c 100644
--- a/fs/xfs/xfs_acl.c
+++ b/fs/xfs/xfs_acl.c
@@ -162,10 +162,11 @@ xfs_get_acl(struct inode *inode, int type)
                 */
                if (error != -ENOATTR)
                        acl = ERR_PTR(error);
-               return acl;
+               goto out;
        }
 
        acl = xfs_acl_from_disk(xfs_acl, len, XFS_ACL_MAX_ENTRIES(ip->i_mount));
+out:
        kmem_free(xfs_acl);
        return acl;
 }
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>