xfs
[Top] [All Lists]

Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_se

To: "Williams, Dan J" <dan.j.williams@xxxxxxxxx>
Subject: Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
From: "Verma, Vishal L" <vishal.l.verma@xxxxxxxxx>
Date: Tue, 29 Mar 2016 18:57:16 +0000
Accept-language: en-US
Cc: "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "viro@xxxxxxxxxxxxxxxxxx" <viro@xxxxxxxxxxxxxxxxxx>, "axboe@xxxxxx" <axboe@xxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "linux-nvdimm@xxxxxxxxxxxx" <linux-nvdimm@xxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "ross.zwisler@xxxxxxxxxxxxxxx" <ross.zwisler@xxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "Wilcox, Matthew R" <matthew.r.wilcox@xxxxxxxxx>, "david@xxxxxxxxxxxxx" <david@xxxxxxxxxxxxx>, "jack@xxxxxxx" <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAPcyv4jFwh679arTNoUzLZpJCSoR+KhMdEmwqddCU1RWOrjD=Q@xxxxxxxxxxxxxx>
References: <1458861450-17705-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1458861450-17705-5-git-send-email-vishal.l.verma@xxxxxxxxx> <CAPcyv4iKK=1Nhz4QqEkhc4gum+UvUS4a=+Sza2zSa1Kyrth41w@xxxxxxxxxxxxxx> <1458939796.5501.8.camel@xxxxxxxxx> <CAPcyv4jWqVcav7dQPh7WHpqB6QDrCezO5jbd9QW9xH3zsU4C1w@xxxxxxxxxxxxxx> <1459195288.15523.3.camel@xxxxxxxxx> <CAPcyv4jFwh679arTNoUzLZpJCSoR+KhMdEmwqddCU1RWOrjD=Q@xxxxxxxxxxxxxx>
Thread-index: AQHRhiNvKoQhiC/aYEiTGtqXM3Dgv59q9p4AgAAl9ACAAATbgIAEoN8AgAA7dACAAUTogA==
Thread-topic: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
On Mon, 2016-03-28 at 16:34 -0700, Dan Williams wrote:

<>

> Seems kind of sad to fail the fault due to a bad block when we were
> going to zero it anyway, right?ÂÂI'm not seeing a compelling reason to
> keep any zeroing in fs/dax.c.

Agreed - but how do we do this? clear_pmem needs to be able to clear an
arbitrary number of bytes, but to go through the driver, we'd need to
send down a bio? If only the driver had an rw_bytes like interface that
could be used by anyone... :)
<Prev in Thread] Current Thread [Next in Thread>