On Fri, 2016-03-25 at 11:47 -0700, Dan Williams wrote:
> On Thu, Mar 24, 2016 at 4:17 PM, Vishal Verma <vishal.l.verma@xxxxxxx
> om> wrote:
> >
> > From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> >
> > dax_clear_sectors() cannot handle poisoned blocks.ÂÂThese must be
> > zeroed using the BIO interface instead.ÂÂConvert ext2 and XFS to
> > use
> > only sb_issue_zerout().
> >
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> > [vishal: Also remove the dax_clear_sectors function entirely]
> > Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> > ---
> > Âfs/dax.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 32 --------------------------------
> > Âfs/ext2/inode.cÂÂÂÂÂÂÂÂ|ÂÂ7 +++----
> > Âfs/xfs/xfs_bmap_util.c |ÂÂ9 ---------
> > Âinclude/linux/dax.hÂÂÂÂ|ÂÂ1 -
> > Â4 files changed, 3 insertions(+), 46 deletions(-)
> >
> > diff --git a/fs/dax.c b/fs/dax.c
> > index bb7e9f8..a30481e 100644
> > --- a/fs/dax.c
> > +++ b/fs/dax.c
> > @@ -78,38 +78,6 @@ struct page *read_dax_sector(struct block_device
> > *bdev, sector_t n)
> > ÂÂÂÂÂÂÂÂreturn page;
> > Â}
> >
> > -/*
> > - * dax_clear_sectors() is called from within transaction context
> > from XFS,
> > - * and hence this means the stack from this point must follow
> > GFP_NOFS
> > - * semantics for all operations.
> > - */
> > -int dax_clear_sectors(struct block_device *bdev, sector_t _sector,
> > long _size)
> > -{
> > -ÂÂÂÂÂÂÂstruct blk_dax_ctl dax = {
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ.sector = _sector,
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ.size = _size,
> > -ÂÂÂÂÂÂÂ};
> > -
> > -ÂÂÂÂÂÂÂmight_sleep();
> > -ÂÂÂÂÂÂÂdo {
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlong count, sz;
> > -
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcount = dax_map_atomic(bdev, &dax);
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (count < 0)
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn count;
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂsz = min_t(long, count, SZ_128K);
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂclear_pmem(dax.addr, sz);
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdax.size -= sz;
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdax.sector += sz / 512;
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdax_unmap_atomic(bdev, &dax);
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcond_resched();
> > -ÂÂÂÂÂÂÂ} while (dax.size);
> > -
> > -ÂÂÂÂÂÂÂwmb_pmem();
> > -ÂÂÂÂÂÂÂreturn 0;
> > -}
> > -EXPORT_SYMBOL_GPL(dax_clear_sectors);
> What about the other unwritten extent conversions in the dax path?
> Shouldn't those be converted to block-layer zero-outs as well?
Could you point me to where these might be? I thought once we've
converted all the zeroout type callers (by removing dax_clear_sectors),
and fixed up dax_do_io to try a driver fallback, we've handled all the
media error cases in dax..
|