xfs
[Top] [All Lists]

[PATCH] Revert "xfs: clear PF_NOFREEZE for xfsaild kthread"

To: xfs@xxxxxxxxxxx
Subject: [PATCH] Revert "xfs: clear PF_NOFREEZE for xfsaild kthread"
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2016 16:12:48 +1100
Cc: jkosina@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
This reverts commit 24ba16bb3d499c49974669cd8429c3e4138ab102 as it
prevents machines from suspending. This regression occurs when the
xfsaild is idle on entry to suspend, and so there s no activity to
wake it from it's idle sleep and hence see that it is supposed to
freeze. Hence the freezer times out waiting for it and suspend is
cancelled.

There is no obvious fix for this short of freezing the filesystem
properly, so revert this change for now.

Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
---
 fs/xfs/xfs_trans_ail.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index aa67339..4f18fd9 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -497,7 +497,6 @@ xfsaild(
        long            tout = 0;       /* milliseconds */
 
        current->flags |= PF_MEMALLOC;
-       set_freezable();
 
        while (!kthread_should_stop()) {
                if (tout && tout <= 20)
-- 
2.5.0

<Prev in Thread] Current Thread [Next in Thread>