| To: | linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, philipp.reisner@xxxxxxxxxx, lars.ellenberg@xxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, osd-dev@xxxxxxxxxxxx, xfs@xxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 29/35] ide cd: do not set REQ_WRITE on requests. |
| From: | mchristi@xxxxxxxxxx |
| Date: | Tue, 5 Jan 2016 14:53:32 -0600 |
| Cc: | Mike Christie <mchristi@xxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1452027218-32303-1-git-send-email-mchristi@xxxxxxxxxx> |
| References: | <1452027218-32303-1-git-send-email-mchristi@xxxxxxxxxx> |
From: Mike Christie <mchristi@xxxxxxxxxx>
The block layer will set the correct READ/WRITE operation flags/fields
when creating a request, so there is not need for drivers to set the
REQ_WRITE flag.
This patch is compile tested only.
Signed-off-by: Mike Christie <mchristi@xxxxxxxxxx>
---
drivers/ide/ide-cd_ioctl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c
index 474173e..5887a7a 100644
--- a/drivers/ide/ide-cd_ioctl.c
+++ b/drivers/ide/ide-cd_ioctl.c
@@ -459,9 +459,6 @@ int ide_cdrom_packet(struct cdrom_device_info *cdi,
layer. the packet must be complete, as we do not
touch it at all. */
- if (cgc->data_direction == CGC_DATA_WRITE)
- flags |= REQ_WRITE;
-
if (cgc->sense)
memset(cgc->sense, 0, sizeof(struct request_sense));
--
1.8.3.1
|
| Previous by Date: | [PATCH 28/35] blktrace: get op from req->op/bio->bi_op, mchristi |
|---|---|
| Next by Date: | [PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs, mchristi |
| Previous by Thread: | [PATCH 28/35] blktrace: get op from req->op/bio->bi_op, mchristi |
| Next by Thread: | [PATCH 30/35] block, fs, drivers: do not test bi_rw for REQ_OPs, mchristi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |