xfs
[Top] [All Lists]

[PATCH 08/11] xfsprogs: xfs_repair: fix possible null dereference in bui

To: xfs@xxxxxxxxxxx
Subject: [PATCH 08/11] xfsprogs: xfs_repair: fix possible null dereference in build_ino_tree
From: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Date: Wed, 02 Dec 2015 16:49:24 +0530
Cc: a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx, Vivek Trivedi <t.vivek@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dlp-filter: Pass
In-reply-to: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
References: <1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx>
Fix possible null dereference in build_ino_tree if ino_rec is NULL.
Reported by coverity.

Signed-off-by: Vivek Trivedi <t.vivek@xxxxxxxxxxx>
---
 repair/phase5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/repair/phase5.c b/repair/phase5.c
index 109e37b..5d95e22 100644
--- a/repair/phase5.c
+++ b/repair/phase5.c
@@ -1235,7 +1235,7 @@ build_ino_tree(xfs_mount_t *mp, xfs_agnumber_t agno,
                if (lptr->modulo > 0)
                        lptr->modulo--;
 
-               if (lptr->num_recs_pb > 0)
+               if (lptr->num_recs_pb > 0 && ino_rec)
                        prop_ino_cursor(mp, agno, btree_curs,
                                        ino_rec->ino_startnum, 0);
 
-- 
1.7.9.5

<Prev in Thread] Current Thread [Next in Thread>